Skip to content

Conversation

@Caranell
Copy link
Member

added with { type: "json" }; to fix builds

Copy link
Member

@0xngmi 0xngmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make sure that if the scripts fail the whole build fails? to avoid the issue we saw before

Updates build.sh to check the exit status of post-export.sh. If post-export fails but the build succeeded, the build status is updated to reflect the failure, ensuring accurate reporting of build results.
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 28, 2025

Deploying chainlist with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7edd976
Status:🚫  Build failed.

View logs

@Caranell
Copy link
Member Author

@mintdart it doesn't work tho? (removed the fix to trigger error)
Screenshot 2025-10-28 at 20 50 14

@Caranell
Copy link
Member Author

Screenshot 2025-10-28 at 20 55 12

I was thinking about adding this to exit 1 if generation script fails

@0xngmi
Copy link
Member

0xngmi commented Oct 28, 2025

if that doesnt work, can also add a try/catch that exits with 1 on the catch

@mintdart
Copy link
Contributor

mintdart commented Nov 6, 2025

@Caranell create is a default import on zustand 4.1.5 i think , local dev server does not start so reverted your commit
Screenshot 2

@Caranell
Copy link
Member Author

Caranell commented Nov 6, 2025

hm weird, I was getting lots of warnings suggesting to fix deprecated import, maybe my local package cache issue

@mintdart
Copy link
Contributor

mintdart commented Nov 6, 2025

@mintdart it doesn't work tho? (removed the fix to trigger error) Screenshot 2025-10-28 at 20 50 14

yeah so it does fail and build also fails right ?
Screenshot 4
before post export script failed but build succeeded

@mintdart
Copy link
Contributor

mintdart commented Nov 6, 2025

if that doesnt work, can also add a try/catch that exits with 1 on the catch

@0xngmi updated to exit with 1 if post export script fails

to test a successful build
replace { paths, fallback: false } with { paths: [], fallback: false } in all getStaticPaths so it is faster to build the app

to test build if the post-export script fails
replace { paths, fallback: false } with { paths: [], fallback: false } and remove with { type: "json" } in utils/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants