-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Sort testnets by tvl #2173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sort testnets by tvl #2173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make sure that if the scripts fail the whole build fails? to avoid the issue we saw before
Updates build.sh to check the exit status of post-export.sh. If post-export fails but the build succeeded, the build status is updated to reflect the failure, ensuring accurate reporting of build results.
|
@mintdart it doesn't work tho? (removed the fix to trigger error) |
|
if that doesnt work, can also add a try/catch that exits with 1 on the catch |
This reverts commit 35c83f2.
|
@Caranell |
|
hm weird, I was getting lots of warnings suggesting to fix deprecated import, maybe my local package cache issue |
yeah so it does fail and build also fails right ? |
@0xngmi updated to exit with 1 if post export script fails to test a successful build to test build if the post-export script fails |





added
with { type: "json" };to fix builds